OER: remove nom usage, improve errors #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicceboy
force-pushed
the
oer-remove-nom
branch
3 times, most recently
from
92c68d3 to
d9e9158
Compare
Nicceboy
force-pushed
the
oer-remove-nom
branch
from
d9e9158 to
3654e15
Compare
|
Thank you for your PR! |
Merged
This was referenced Dec 30, 2024
Merged
Merged
This was referenced Jan 25, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OER decoding has simplified a bit and we can actually just remove
nomusage completely.This improves error messages slightly as well at the same time, and move some historical constants.