Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play button not working. #4784

Closed
3 tasks done
Doktor515 opened this issue Sep 16, 2023 · 2 comments · Fixed by #4797
Closed
3 tasks done

Play button not working. #4784

Doktor515 opened this issue Sep 16, 2023 · 2 comments · Fixed by #4797
Labels
bug Something isn't working

Comments

@Doktor515
Copy link

Steps to reproduce

1.Play the video and press the stop button
2.Press the Play button. The video does not play

Expected behavior

Let the play button work immediately.

Actual behavior

The button does not respond.The previous stable version did not have this problem

XRecorder_16092023_130444.mp4

LibreTube version

0.18.0

Android version

Android 12

Other details

A)1.This problem occurs when I return to the player after background playback is interrupted
2.Sometimes the player stops suddenly while in the application.Sometimes the player stops frequently and the quality drops. The button does not work.
B)Other possible wrongs.
1.Sometimes, when opening a video, the player does not show the loading icon
2.The bottom panel sometimes does not load

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@Doktor515 Doktor515 added the bug Something isn't working label Sep 16, 2023
@DanielProg39
Copy link

DanielProg39 commented Sep 16, 2023

I also came across this bug several times. I came to a conclusion that in my case this problem occurs when the video stops for app to load the next chunk. The play button is inactive during loading and stays inactive after the chunk is loaded, without changing its state when the video is stopped and the button is showed again.
Here's my screen recording showcasing this bug along with #4785 and #4470

screen-20230915-213428.mp4

@IndusAryan
Copy link
Contributor

yes,this started after implementation of this #4498

FineFindus added a commit to FineFindus/LibreTube that referenced this issue Sep 17, 2023
Fixes libre-tube#4784, the player should only pause when it has no buffer to play, not when it is loading, as it always loads, until the allocated buffer is full.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants