Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tooltips to various icon buttons for better accessibility #4472

Merged
merged 8 commits into from
Aug 15, 2023

Conversation

FineFindus
Copy link
Contributor

Adds tooltips to various icon buttons. This not only helps with accessibility, but is also useful for new users, who may not immediately associate an icon with a certain action.
I most likely missed some, in that case, I will try to do to a follow-up pr once I notice them.

@Bnyro
Copy link
Member

Bnyro commented Aug 14, 2023

Looks like a great enhancement! Please run ktlint --android -F to fix the linter.

@FineFindus
Copy link
Contributor Author

Thanks! I was about to investigate the CI failure, when Android Studio decided to crash and take my Wayland session with it. Guess it is enough android dev for today (once the linter is finally happy :) )

@Bnyro
Copy link
Member

Bnyro commented Aug 15, 2023

I'm planning to do a bug fix release soon, so I want to merge new features after that release has published. Hope you're fine with waiting a bit until we're merging this :)

@Bnyro
Copy link
Member

Bnyro commented Aug 15, 2023

Since it's not supported for some Android versions, I would prefer an extension function ImageView#trySetTooltip which does the version check any set the tooltip if supported by the Android version.
So that we don't need to do the version check everywhere.

@Bnyro Bnyro changed the title feat: add tooltips feat: add tooltips to various icon buttons for better accessibility Aug 15, 2023
@Bnyro Bnyro merged commit eef864a into libre-tube:master Aug 15, 2023
3 checks passed
@Bnyro
Copy link
Member

Bnyro commented Aug 15, 2023

Thank you!

@FineFindus FineFindus deleted the feat/tooltips branch August 15, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants