Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: npe when opening dialog to submit sb segments #4625

Merged
merged 1 commit into from
Aug 25, 2023
Merged

fix: npe when opening dialog to submit sb segments #4625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions app/src/main/java/com/github/libretube/ui/dialogs/SubmitSegmentDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,8 @@ class SubmitSegmentDialog(
private val currentPosition: Long,
private val duration: Long?
) : DialogFragment() {
private var _binding: DialogSubmitSegmentBinding? = null
private val binding = _binding!!

override fun onCreateDialog(savedInstanceState: Bundle?): Dialog {
_binding = DialogSubmitSegmentBinding.inflate(layoutInflater)
val binding = DialogSubmitSegmentBinding.inflate(layoutInflater)

binding.startTime.setText((currentPosition.toFloat() / 1000).toString())

Expand All @@ -51,14 +48,14 @@ class SubmitSegmentDialog(
requireDialog().hide()

lifecycleScope.launch {
submitSegment()
submitSegment(binding)
dismiss()
}
}
}
}

private suspend fun submitSegment() {
private suspend fun submitSegment(binding: DialogSubmitSegmentBinding) {
val context = requireContext().applicationContext

val startTime = binding.startTime.text.toString().toFloatOrNull()
Expand Down Expand Up @@ -89,9 +86,4 @@ class SubmitSegmentDialog(
context.toastFromMainDispatcher(e.localizedMessage.orEmpty())
}
}

override fun onDestroyView() {
super.onDestroyView()
_binding = null
}
}
Loading