Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove arguments from dialog fragment constructors #4684

Merged
merged 8 commits into from
Sep 8, 2023
Merged

refactor: remove arguments from dialog fragment constructors #4684

merged 8 commits into from
Sep 8, 2023

Commits on Sep 8, 2023

  1. refactor: use Bundle for DialogFragment arguments

    @anshtya @Bnyro
    anshtya authored and Bnyro committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    995868b View commit details
    Browse the repository at this point in the history

  2. refactor: save keys of Bundle in IntentData

    @anshtya @Bnyro
    anshtya authored and Bnyro committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    7f80d97 View commit details
    Browse the repository at this point in the history

  3. refactor: retrieve videoId out of arguments block

    @anshtya @Bnyro
    anshtya authored and Bnyro committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    96c2f28 View commit details
    Browse the repository at this point in the history

  4. refactor: add keys and change playlistDescription key in IntentData

    @anshtya @Bnyro
    anshtya authored and Bnyro committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    77f9fcb View commit details
    Browse the repository at this point in the history

  5. refactor: use extension function for receiving arguments

    @anshtya @Bnyro
    anshtya authored and Bnyro committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    35565ad View commit details
    Browse the repository at this point in the history

  6. refactor: use Bundle for DialogFragment arguments 

    - AddToPlaylistDialog
- BackupDialog
- CreatePlaylistDialog
- DeleteAccountDialog
- LoginDialog
- LogoutDialog
    @anshtya @Bnyro
    anshtya authored and Bnyro committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    1044fcd View commit details
    Browse the repository at this point in the history

  7. refactor: use Bundle for DialogFragment arguments 

    - ColorPickerDialog
- DeletePlaylistDialog
- RenamePlaylistDialog
    @anshtya @Bnyro
    anshtya authored and Bnyro committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    f260c48 View commit details
    Browse the repository at this point in the history

  8. fix: update ui when renaming playlist or changing its description

    @Bnyro
    Bnyro committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    3d4a9a0 View commit details
    Browse the repository at this point in the history