Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update navigation to v2.7.2 #4705

Merged
merged 1 commit into from
Sep 7, 2023

fix(deps): update navigation to v2.7.2

b835ab2
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix(deps): update navigation to v2.7.2 #4705

fix(deps): update navigation to v2.7.2
b835ab2
Select commit
Loading
Failed to load commit list.
GitHub Actions / ktlint succeeded Sep 6, 2023 in 0s

reviewdog [ktlint] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (106)

app/src/main/java/com/github/libretube/api/PipedApi.kt|51 col 9| No whitespace expected between opening parenthesis and first parameter name
app/src/main/java/com/github/libretube/api/PipedApi.kt|51 col 44| No whitespace expected between last parameter and closing parenthesis
app/src/main/java/com/github/libretube/api/PipedApi.kt|120 col 9| No whitespace expected between opening parenthesis and first parameter name
app/src/main/java/com/github/libretube/api/PipedApi.kt|120 col 44| No whitespace expected between last parameter and closing parenthesis
app/src/main/java/com/github/libretube/api/PipedApi.kt|125 col 9| No whitespace expected between opening parenthesis and first parameter name
app/src/main/java/com/github/libretube/api/PipedApi.kt|125 col 37| No whitespace expected between last parameter and closing parenthesis
app/src/main/java/com/github/libretube/api/PipedApi.kt|144 col 9| No whitespace expected between opening parenthesis and first parameter name
app/src/main/java/com/github/libretube/api/PipedApi.kt|144 col 37| No whitespace expected between last parameter and closing parenthesis
app/src/main/java/com/github/libretube/api/SubscriptionHelper.kt|115 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/api/SubscriptionHelper.kt|133 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/api/obj/Streams.kt|44 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/api/obj/Streams.kt|56 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/api/obj/Streams.kt|96 col 19| Property name should use the screaming snake case notation when the value can not be changed
app/src/main/java/com/github/libretube/constants/IntentData.kt|4 col 15| Property name should use the screaming snake case notation when the value can not be changed
app/src/main/java/com/github/libretube/constants/IntentData.kt|5 col 15| Property name should use the screaming snake case notation when the value can not be changed
app/src/main/java/com/github/libretube/constants/IntentData.kt|6 col 15| Property name should use the screaming snake case notation when the value can not be changed
app/src/main/java/com/github/libretube/constants/IntentData.kt|7 col 15| Property name should use the screaming snake case notation when the value can not be changed
app/src/main/java/com/github/libretube/constants/IntentData.kt|8 col 15| Property name should use the screaming snake case notation when the value can not be changed
app/src/main/java/com/github/libretube/constants/IntentData.kt|9 col 15| Property name should use the screaming snake case notation when the value can not be changed
app/src/main/java/com/github/libretube/constants/IntentData.kt|10 col 15| Property name should use the screaming snake case notation when the value can not be changed
app/src/main/java/com/github/libretube/constants/IntentData.kt|11 col 15| Property name should use the screaming snake case notation when the value can not be changed
app/src/main/java/com/github/libretube/constants/IntentData.kt|12 col 15| Property name should use the screaming snake case notation when the value can not be changed
app/src/main/java/com/github/libretube/constants/IntentData.kt|13 col 15| Property name should use the screaming snake case notation when the value can not be changed
app/src/main/java/com/github/libretube/constants/IntentData.kt|14 col 15| Property name should use the screaming snake case notation when the value can not be changed
app/src/main/java/com/github/libretube/constants/IntentData.kt|15 col 15| Property name should use the screaming snake case notation when the value can not be changed
app/src/main/java/com/github/libretube/constants/IntentData.kt|16 col 15| Property name should use the screaming snake case notation when the value can not be changed
app/src/main/java/com/github/libretube/constants/IntentData.kt|17 col 15| Property name should use the screaming snake case notation when the value can not be changed
app/src/main/java/com/github/libretube/db/DatabaseHelper.kt|25 col 9| No whitespace expected between opening parenthesis and first parameter name
app/src/main/java/com/github/libretube/db/DatabaseHelper.kt|26 col 9| Single whitespace expected before parameter
app/src/main/java/com/github/libretube/db/DatabaseHelper.kt|26 col 27| No whitespace expected between last parameter and closing parenthesis
app/src/main/java/com/github/libretube/db/DatabaseHelper.kt|27 col 9| Newline expected before expression body
app/src/main/java/com/github/libretube/enums/SupportedClient.kt|1 col 1| File 'SupportedClient.kt' contains a single class and possibly also extension functions for that class and should be named same after that class 'ImportFormat.kt'
app/src/main/java/com/github/libretube/extensions/Tag.kt|3 col 9| Function name should start with a lowercase letter (except factory methods) and use camel case
app/src/main/java/com/github/libretube/helpers/BackupHelper.kt|95 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/helpers/DashHelper.kt|180 col 9| No whitespace expected between opening parenthesis and first parameter name
app/src/main/java/com/github/libretube/helpers/DashHelper.kt|181 col 9| Single whitespace expected before parameter
app/src/main/java/com/github/libretube/helpers/DashHelper.kt|181 col 28| No whitespace expected between last parameter and closing parenthesis
app/src/main/java/com/github/libretube/helpers/ImageHelper.kt|3 col 1| Imports must be ordered in lexicographic order without any empty lines in-between
app/src/main/java/com/github/libretube/helpers/NavigationHelper.kt|28 col 9| No whitespace expected between opening parenthesis and first parameter name
app/src/main/java/com/github/libretube/helpers/NavigationHelper.kt|29 col 9| Single whitespace expected before parameter
app/src/main/java/com/github/libretube/helpers/NavigationHelper.kt|29 col 27| No whitespace expected between last parameter and closing parenthesis
app/src/main/java/com/github/libretube/helpers/NavigationHelper.kt|88 col 9| No whitespace expected between opening parenthesis and first parameter name
app/src/main/java/com/github/libretube/helpers/NavigationHelper.kt|89 col 9| Single whitespace expected before parameter
app/src/main/java/com/github/libretube/helpers/NavigationHelper.kt|90 col 9| Single whitespace expected before parameter
app/src/main/java/com/github/libretube/helpers/NavigationHelper.kt|90 col 35| No whitespace expected between last parameter and closing parenthesis
app/src/main/java/com/github/libretube/helpers/NotificationHelper.kt|19 col 9| No whitespace expected between opening parenthesis and first parameter name
app/src/main/java/com/github/libretube/helpers/NotificationHelper.kt|20 col 9| Single whitespace expected before parameter
app/src/main/java/com/github/libretube/helpers/NotificationHelper.kt|20 col 63| No whitespace expected between last parameter and closing parenthesis
app/src/main/java/com/github/libretube/helpers/PlayerHelper.kt|95 col 19| No comment expected at this location
app/src/main/java/com/github/libretube/helpers/PlayerHelper.kt|431 col 28| A comment in a 'value_argument_list' is only allowed when placed on a separate line
app/src/main/java/com/github/libretube/helpers/ThemeHelper.kt|37 col 9| No whitespace expected between opening parenthesis and first parameter name
app/src/main/java/com/github/libretube/helpers/ThemeHelper.kt|37 col 36| No whitespace expected between last parameter and closing parenthesis
app/src/main/java/com/github/libretube/helpers/ThemeHelper.kt|121 col 9| No whitespace expected between opening parenthesis and first parameter name
app/src/main/java/com/github/libretube/helpers/ThemeHelper.kt|122 col 9| Single whitespace expected before parameter
app/src/main/java/com/github/libretube/helpers/ThemeHelper.kt|122 col 23| No whitespace expected between last parameter and closing parenthesis
app/src/main/java/com/github/libretube/helpers/ThemeHelper.kt|123 col 9| Newline expected before expression body
app/src/main/java/com/github/libretube/helpers/ThemeHelper.kt|136 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/services/DownloadService.kt|375 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/services/DownloadService.kt|530 col 13| Property name should start with a lowercase letter and use camel case
app/src/main/java/com/github/libretube/services/OnlinePlayerService.kt|377 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/ui/activities/MainActivity.kt|139 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/ui/activities/MainActivity.kt|355 col 17| No comment expected at this location
app/src/main/java/com/github/libretube/ui/adapters/NavBarOptionsAdapter.kt|33 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/ui/adapters/VideosAdapter.kt|48 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt|39 col 17| No whitespace expected between opening parenthesis and first parameter name
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt|40 col 17| Single whitespace expected before parameter
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt|41 col 17| Single whitespace expected before parameter
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt|42 col 17| Single whitespace expected before parameter
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt|42 col 27| No whitespace expected between last parameter and closing parenthesis
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt|43 col 17| Newline expected before expression body
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt|46 col 17| No whitespace expected between opening parenthesis and first parameter name
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt|47 col 17| Single whitespace expected before parameter
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt|48 col 17| Single whitespace expected before parameter
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt|49 col 17| Single whitespace expected before parameter
app/src/main/java/com/github/libretube/ui/dialogs/ColorPickerDialog.kt|49 col 27| No whitespace expected between last parameter and closing parenthesis
app/src/main/java/com/github/libretube/ui/fragments/AudioPlayerFragment.kt|3 col 1| Imports must be ordered in lexicographic order without any empty lines in-between
app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt|660 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt|725 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt|777 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt|1091 col 9| No whitespace expected between opening parenthesis and first parameter name
app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt|1092 col 9| Single whitespace expected before parameter
app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt|1092 col 28| No whitespace expected between last parameter and closing parenthesis
app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt|1636 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/ui/fragments/PlaylistFragment.kt|342 col 21| No whitespace expected between opening parenthesis and first parameter name
app/src/main/java/com/github/libretube/ui/fragments/PlaylistFragment.kt|343 col 21| Single whitespace expected before parameter
app/src/main/java/com/github/libretube/ui/fragments/PlaylistFragment.kt|343 col 35| No whitespace expected between last parameter and closing parenthesis
app/src/main/java/com/github/libretube/ui/fragments/SubscriptionsFragment.kt|90 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/ui/fragments/WatchHistoryFragment.kt|131 col 17| No whitespace expected between opening parenthesis and first parameter name
app/src/main/java/com/github/libretube/ui/fragments/WatchHistoryFragment.kt|132 col 17| Single whitespace expected before parameter
app/src/main/java/com/github/libretube/ui/fragments/WatchHistoryFragment.kt|132 col 31| No whitespace expected between last parameter and closing parenthesis
app/src/main/java/com/github/libretube/ui/listeners/PlayerGestureController.kt|63 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/ui/listeners/PlayerGestureController.kt|147 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/ui/listeners/PlayerGestureController.kt|150 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/ui/preferences/AppearanceSettings.kt|83 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/ui/sheets/ChaptersBottomSheet.kt|54 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/ui/sheets/StatsSheet.kt|49 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/ui/views/CustomExoPlayerView.kt|634 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/ui/views/OnlinePlayerView.kt|84 col 1| Exceeded max line length (100)
app/src/main/java/com/github/libretube/util/NowPlayingNotification.kt|321 col 9| No whitespace expected between opening parenthesis and first parameter name
app/src/main/java/com/github/libretube/util/NowPlayingNotification.kt|322 col 9| Single whitespace expected before parameter
app/src/main/java/com/github/libretube/util/NowPlayingNotification.kt|322 col 37| No whitespace expected between last parameter and closing parenthesis
app/src/main/java/com/github/libretube/util/YouTubeHlsPlaylistParser.kt|1 col 1| File 'YouTubeHlsPlaylistParser.kt' contains a single class and possibly also extension functions for that class and should be named same after that class 'YoutubeHlsPlaylistParser.kt'
app/src/main/java/com/github/libretube/util/YouTubeHlsPlaylistParser.kt|217 col 9| No whitespace expected between opening parenthesis and first parameter name
app/src/main/java/com/github/libretube/util/YouTubeHlsPlaylistParser.kt|218 col 9| Single whitespace expected before parameter
app/src/main/java/com/github/libretube/util/YouTubeHlsPlaylistParser.kt|218 col 27| No whitespace expected between last parameter and closing parenthesis
app/src/main/java/com/github/libretube/workers/NotificationWorker.kt|193 col 52| A comment in a 'value_argument_list' is only allowed when placed on a separate line