feat: option to autoplay videos in playlist

[FineFindus]

Currently, playing a playlist is only possible when autoplay is enabled.
This pr changes this and autoplays all videos in a playlist without autoplay being enabled.

[IndusAryan]

whats point of autoplay preference then?

[FineFindus]

Autoplay plays the next video after the current one finishes. This is done regardless if the watched video was just a single video or part of a playlist.
Enabling autoplay will still continue to play the next video, this only affects the behavior if the user is watching a playlist.

[Bnyro]

The same behavior can be achieved by disabling "Insert related items to queue" and enabling autoplay.

I don't see why we should automatically play the next videos even though the user explicitly disabled it (Autoplay is enabled by default).

[FineFindus]

I would consider myself a fairly experienced user (I both use the app a lot and have contributed to it), and yet I had no idea that this combination of settings achieves the desired behavior. How is a new and inexperienced user supposed to discover this?
They might just disable autoplay because they don't like it, and later try to play a playlist, but it only plays one video at a time. From their experience, the application is obviously broken because it breaks with already established concepts in other applications (e.g. playlists in YouTube play all videos even if autoplay is disabled).

Also, I think the user group that clicks on a playlist and expects it to play only one video at a time is pretty small or nonexistent.

[Silther]

You could make this change optional.
If you can't disable autoplay anymore, it woudn't be very useful for most people.
See #1810.

[Bnyro]

I would consider myself a fairly experienced user (I both use the app a lot and have contributed to it), and yet I had no idea that this combination of settings achieves the desired behavior. How is a new and inexperienced user supposed to discover this?

I don't expect any new user to discover this option, however:

• we have an open issue that focuses on improving the organization of the settings
• the user can temporarily enable autoplay

I'd be okay with adding an option to autoplay playlists.

Nevertheless this should also affect the background mode / audio only player too.

[FineFindus]

Added a setting for it and changed the code in OnlinePlayerService (I this one is responsible for background play?).
Not sure how to support the audio only player, as it doesn't even support autoplay.

[Bnyro]

Added a setting for it and changed the code in OnlinePlayerService (I this one is responsible for background play?). Not sure how to support the audio only player, as it doesn't even support autoplay.

Just make PlayerHelper.autoPlay a private var and replace it where the compilation fails.

The background / audio only mode does support autoplay though.

[Bnyro]

Bnyro you added thousand lines for this 😂

That's unrelated to this PR, and in fact it's mainly useful for the banner of a channel, not its avatar.

[FineFindus]

I already replaced it everywhere, except for the autoplay switches themselves.

The background / audio only mode does support autoplay though.

Hmm, odd, I can't get it to work