Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: RYD support for local stream extraction #6483

Merged
merged 4 commits into from
Sep 14, 2024

Conversation

janisslsm
Copy link
Contributor

fixes #6412

perhaps adding a toggle under local stream extraction would be useful in case someone doesn't want it? I wasn't sure so I didn't add one.

@Bnyro
Copy link
Member

Bnyro commented Sep 12, 2024

I'd prefer to make this a preference (enabled by default)

@janisslsm
Copy link
Contributor Author

I'd prefer to make this a preference (enabled by default)

Screenshot_20240912_185856
is this fine?

@ChunkyProgrammer
Copy link

There's also ryd proxy, not sure if you'd want to support using that as well https://github.com/TeamPiped/RYD-Proxy (the api call is slightly different)

@Bnyro
Copy link
Member

Bnyro commented Sep 14, 2024

There's also ryd proxy, not sure if you'd want to support using that as well https://github.com/TeamPiped/RYD-Proxy (the api call is slightly different)

I think that's an overkill for now.

additionally return -1 if no dislikes were fetched.

Co-authored-by: Bnyro <bnyro@tutanota.com>
Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bnyro Bnyro merged commit 66ccdf1 into libre-tube:master Sep 14, 2024
3 checks passed
@janisslsm janisslsm deleted the feat-ryd-local branch September 14, 2024 09:42
@Bnyro Bnyro mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return YouTube dislike support for local streams extraction
3 participants