fix(MarkableTimeBar): align segments to timebar #7055
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That seems to be off for 1 or 2 pixels on my device :/ |
|
Damn :( Was it aligned correctly before? I guess this means we need to follow the height calculation more closely (or fork and make the height public; that would also enable #4575 :)) |
It was for me, yes.
Yes, there's probably some error in the general way we try to calculate the height with, probably rebuilding that calculation from scratch makes sense. |
FineFindus
force-pushed
the
fix/timebar-alignment
branch
from
9e5cd92 to
2c556ab
Compare
Due to a error in the timebar position calculation, segments could be msialigned by a pixel. This is fixed by using a caculation that more closely matches how the actual timebar is drawn.
FineFindus
force-pushed
the
fix/timebar-alignment
branch
from
2c556ab to
ea6483d
Compare
|
I've updated the calculation to be pretty much the same as in exoplayer. Could you please re-test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The segments drawn on the timeline seem to be off by one pixel. I'm not quite sure what's causing this, as the calculation is done differently to the timeline itself.
Since the calculation depends on the device, and I haven't been able to test this on multiple devices, further testing should be done before merging.