Allow client redirect URI with only a scheme #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The redirect URI can have the form `protocol:action` which is basically just a scheme. This is entirely valid and since such URI do not have a host the validation of the redirect_uri request parameter fails. This change does no longer check the host part of the URI to be non-empty, fixing client support for clients using such URIs. Fixes: libregraph#161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The redirect URI can have the form
protocol:actionwhich is basically just a scheme. This is entirely valid and since such URI do not have a host the validation of the redirect_uri request parameter fails.This change does no longer check the host part of the URI to be non-empty, fixing client support for clients using such URIs.
Fixes: #161