-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TESTING.md #1065
base: master
Are you sure you want to change the base?
Update TESTING.md #1065
Conversation
Add a warning advising that latest lime packages breaks the interfaces configurations
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1065 +/- ##
==========================================
+ Coverage 79.69% 79.71% +0.02%
==========================================
Files 53 53
Lines 4550 4550
==========================================
+ Hits 3626 3627 +1
+ Misses 924 923 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some grammar changes and a suggestion to include a link to a prebuilt OpenWRT 23 image.
> Since the commit https://github.com/libremesh/lime-packages/commit/64b7c01961c6e7bc776f83523aea9264724b3b23 lime packages breaks the qemu image and the interfaces cannot be setted up! | ||
> This is due the migration to newer version of OpenWRT. | ||
> To use latest lime packages use a OpenWRT 23 image . | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can also add a link to a prebuilt OpenWRT 23 image.
> | |
> New prebuilt images can be downloaded from here: | |
> * https://repo.libremesh.org/releases/2023.1-rc2-ow22/targets/x86/64/libremesh-2023.1-rc2-ow22-default-x86-64-generic-rootfs.tar.gz | |
> * https://repo.libremesh.org/releases/2023.1-rc2-ow22/targets/x86/64/libremesh-2023.1-rc2-ow22-default-x86-64-generic-initramfs-kernel.bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we should link non official repos here..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we should link non official repos here..
also further testing has to be done... Let's leave this text behind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added reference to official repo images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed the problem and this warning is very useful.
These images seem to fix the problem https://firmware-libremesh.antennine.campiinrete.org/releases/master-ow23/targets/x86/64/libremesh-master-ow23-default-x86-64-generic-rootfs.tar.gz
https://firmware-libremesh.antennine.campiinrete.org/releases/master-ow23/targets/x86/64/libremesh-master-ow23-default-x86-64-generic-initramfs-kernel.bin
In my opinion, the solution is not to add a warning, but to fix the issue.
|
Add a warning advising that latest lime packages breaks the interfaces configurations