hotplug-initd-observer: Avoid format error when evData.service is empty #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirm that with Lua 5.1.5 as installed on OpenWrt 23.05.5, the string.format fails when a variable is not existing. I also tested that adding |
|
Sorry, I can't test this, because I can't reproduce it any more. |
|
No worries. I tested that a situation giving that error message gets fixed by this pull request on OpenWrt 23.05.5. So I would say that this is ready to merge (but the pull request needs the approval of some other LibreMesh organization member...). |
G10h4ck
approved these changes
Dec 27, 2024
|
Picked in branch 2024.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1064 (see also #1068)
Please, @LaneaLucy or @pony1k, can you test if this fixes?
Unexpectedly, running a similar code on my laptop with Lua 5.4.7 does not result in an error. Maybe it is related to the older versions of Lua?