Fix initial volume showing zero but playing full volume (#1373)

librespot-org · Oct 17, 2024 · d8e8423 · d8e8423
1 parent 1912065
commit d8e8423
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Removed
 
+### Fixed 
+
+- [connect] Fixes initial volume showing zero despite playing in full volume instead
+
 ## [0.5.0] - 2024-10-15
 
 This version is be a major departure from the architecture up until now. It

diff --git a/connect/src/spirc.rs b/connect/src/spirc.rs
@@ -1509,7 +1509,7 @@ impl SpircTask {
     fn set_volume(&mut self, volume: u16) {
         let old_volume = self.device.volume();
         let new_volume = volume as u32;
-        if old_volume != new_volume {
+        if old_volume != new_volume || self.mixer.volume() != volume {
             self.device.set_volume(new_volume);
             self.mixer.set_volume(volume);
             if let Some(cache) = self.session.cache() {