Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librespot-audio: update librespot-tremor. #585

Merged
merged 4 commits into from
Feb 2, 2021
Merged

librespot-audio: update librespot-tremor. #585

merged 4 commits into from
Feb 2, 2021

Conversation

ericonr
Copy link
Contributor

@ericonr ericonr commented Jan 28, 2021

This picks up a fix for librespot-tremor when building with Rust 1.48.

I'm making this PR to make the update path after librespot-org/librespot-tremor#1 as fast as possible. I hope once that's merged we get a new release soon, and I'm assuming it will be 0.2.0. I can change this or the PR can be superseded by someone else, just wanted to fast track it if possible.

This picks up a fix for librespot-tremor when building with Rust 1.48.
@sashahilton00 sashahilton00 changed the base branch from dev to album-normalisation January 30, 2021 03:15
@sashahilton00 sashahilton00 changed the base branch from album-normalisation to dev January 30, 2021 03:15
@Johannesd3
Copy link
Contributor

Johannesd3 commented Jan 30, 2021

The issue with the build in 1.40 seems to be the "object" crate that was previously locked to 0.22. Why did it jump to 0.23 exactly here?

@sashahilton00
Copy link
Member

The issue with the build in 1.40 seems to be the "object" crate that was previously locked to 0.22. Why did it jump to 0.23 exactly here?

I updated the Cargo.lock file to reflect the tremor version bump, but used cargo update as opposed to cargo update -p librespot-tremor --precise 0.2.0, hence everything got bumped. Have just merged in latest changes to dev, reverted and repushed the updated Cargo.lock

@sashahilton00 sashahilton00 merged commit 4990351 into librespot-org:dev Feb 2, 2021
@ericonr ericonr deleted the patch-1 branch February 2, 2021 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants