[Tokio migration] Make RodioSink Send and other improvements #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| list_formats(&default_device); | ||
|
|
||
| println!("Other Available Audio Devices:"); |
There was a problem hiding this comment.
Was println! before, but would this not make more sense to be info!? Like in general have no println! in the lib because it can not be filtered?
There was a problem hiding this comment.
This is just executed in the case someone specifies "?" as device name and explicitly wishes to see the available devices.
Johannesd3
added a commit
to Johannesd3/librespot
that referenced
this pull request
Apr 9, 2021
Firstly, fe37186 added the restriction that `Sink`s must be `Send`. It turned out later that this restrictions was unnecessary, and since some `Sink`s aren't `Send` yet, this restriction is lifted again. librespot-org#601 refactored the `RodioSink` in order to make it `Send`. These changes are partly reverted in favour of the initial simpler design. There were also some compile errors in the gstreamer backend which are hereby solved.
Johannesd3
added a commit
to Johannesd3/librespot
that referenced
this pull request
Apr 9, 2021
fe37186 added the restriction that `Sink`s must be `Send`. It turned out later that this restrictions was unnecessary, and since some `Sink`s aren't `Send` yet, this restriction is lifted again. librespot-org#601 refactored the `RodioSink` in order to make it `Send`. These changes are partly reverted in favour of the initial simpler design. Furthermore, there were some compile errors in the gstreamer backend which are hereby fixed.
Johannesd3
added a commit
to Johannesd3/librespot
that referenced
this pull request
Apr 9, 2021
fe37186 added the restriction that `Sink`s must be `Send`. It turned out later that this restrictions was unnecessary, and since some `Sink`s aren't `Send` yet, this restriction is lifted again. librespot-org#601 refactored the `RodioSink` in order to make it `Send`. These changes are partly reverted in favour of the initial simpler design. Furthermore, there were some compile errors in the gstreamer backend which are hereby fixed.
Johannesd3
added a commit
to Johannesd3/librespot
that referenced
this pull request
Apr 9, 2021
fe37186 added the restriction that `Sink`s must be `Send`. It turned out later that this restrictions was unnecessary, and since some `Sink`s aren't `Send` yet, this restriction is lifted again. librespot-org#601 refactored the `RodioSink` in order to make it `Send`. These changes are partly reverted in favour of the initial simpler design. Furthermore, there were some compile errors in the gstreamer backend which are hereby fixed.
Johannesd3
added a commit
to Johannesd3/librespot
that referenced
this pull request
Apr 9, 2021
fe37186 added the restriction that `Sink`s must be `Send`. It turned out later that this restrictions was unnecessary, and since some `Sink`s aren't `Send` yet, this restriction is lifted again. librespot-org#601 refactored the `RodioSink` in order to make it `Send`. These changes are partly reverted in favour of the initial simpler design. Furthermore, there were some compile errors in the gstreamer backend which are hereby fixed.
Johannesd3
added a commit
to Johannesd3/librespot
that referenced
this pull request
Apr 9, 2021
fe37186 added the restriction that `Sink`s must be `Send`. It turned out later that this restrictions was unnecessary, and since some `Sink`s aren't `Send` yet, this restriction is lifted again. librespot-org#601 refactored the `RodioSink` in order to make it `Send`. These changes are partly reverted in favour of the initial simpler design. Furthermore, there were some compile errors in the gstreamer backend which are hereby fixed.
Johannesd3
added a commit
to Johannesd3/librespot
that referenced
this pull request
Apr 10, 2021
fe37186 added the restriction that `Sink`s must be `Send`. It turned out later that this restrictions was unnecessary, and since some `Sink`s aren't `Send` yet, this restriction is lifted again. librespot-org#601 refactored the `RodioSink` in order to make it `Send`. These changes are partly reverted in favour of the initial simpler design. Furthermore, there were some compile errors in the gstreamer backend which are hereby fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, this PR fixes two bugs in the playback crate (well, I also introduced them).
Secondly,
RodioSinkwas modified such that it implementsSendnow. The solution spawns an own thread to create therodio::OutputStream. WhenRodioSinkis dropped, this thread is notified via a channel and theOutputStreamis dropped as well. SoRodioSinkdoesn't carry theOutputStreamanymore and is nowSend.I also used this occasion to improve the error handling in the
RodioSinkusingthiserror, but this should only be the beginning.If it's ok, I will continue with those relatively small PRs for the tokio migration, so it's easier to follow what I'm doing and easier to contribute.