separated stream for each seek #664
Conversation
|
Opinions? |
| eos: bool, | ||
| bos: bool, | ||
| ofsgp_page: u64, |
There was a problem hiding this comment.
I never understood why C programmers are afraid of using many letters for variables.
There was a problem hiding this comment.
ah, I started a long time ago to be a DSP programmer as well as doing x86 assembly code. C was a luxury and you had to count every byte, so I kept the "frugal" mindset from these days. Even when I do Perl, which is my 2nd lmost used language after C, I have the same habit. And I like Perl because of the compactness of expressions you can write ;-)
Having said that, it's also because the Rust formater shrinks everything to 80 columns and that, I find it absolutely crazy in 2021. I think these days are long gone and even Linux Torvald :-) thinks that should be changed. So that 80 column pushed the habit of short variable names because having 10 lines of text for one line of code is ugly, IMHO.
Last but not least, I'm always trying to fit with the style of the code I'm adding my changes to and this started from the "ogg/vorbis" library that uses that same short naming for offset and granule.
Co-authored-by: Johannesd3 <51954457+Johannesd3@users.noreply.github.com>
|
From a code perspective this looks fine. I also can't comment on the logic though, since I'm not particularly familiar with the vorbis spec. If anyone has any views on why this shouldn't be merged, voice them, otherwise I'll assume we're good to merge this in a few days. |
|
@peet1993, does that work for you? |
|
It works exactly how you described it, the BOS is there, so yes :) Thanks for implementing it! |
Per #654 it's probably a better idea to have a separated stream every time the user seeks through the same track. It also makes code simpler and solves the issue with potentially missing BoS. The only case where the EoS might miss is when skipping tracks.