Eliminate most uses of util module #668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johannesd3
force-pushed
the
diffie-hellman
branch
from
5b8d9aa to
9964b46
Compare
Johannesd3
changed the title
|
Why is the MSRV being bumped to 1.45? Ideally we'd keep it at 1.41 so that it can be compiled on Debian stable. |
|
IIRC it's the MSRV of Tokio 1.0 |
|
Ah right, ignore my previous comment, missed that this was a PR against the |
|
Also expect a new Debian stable to land in July with Rust 1.48. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems as if Diffie Hellman works exactly the same way in core and discovery, but except of the constants the code wasn't reused until now.
Sequel: Without the use of
powmin discovery, it became unnecessary that this function is exposed in the util module. Looking through the other uses ofutil, I realized that most of them are easy to replace. The last remaining item inutilisSeqGeneratoras it is used once inspirc.rs.