[Tokio migration] Add back hyper-proxy #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like hyper-proxy 0.9.1 was just released. Really awesome work the whole migration! I think this will significantly improve the crate. |
Johannesd3
force-pushed
the
proxy-support
branch
from
5c69555 to
6fca619
Compare
|
Yeah, I updated the commit using 0.9.1, so it should work now as intended (Edit: Actually I didn't stage my changes, but my second try successed) |
Johannesd3
force-pushed
the
proxy-support
branch
from
6fca619 to
95fedf5
Compare
nagua
approved these changes
Mar 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds back the latest version of hyper-proxy. (It was removed as the migration to tokio was not finished yet). I also restored the old behaviour in some places I believe my refactoring was too eager.
I think it is the last major step before #665 is ready.
Unfortunately, it is blocked by tafia/hyper-proxy#23.