-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compat/stdint.h
missing from source tarball
#1064
Comments
I've neutered that with a bigger hammer:
openbsd/src@65010fa
|
Perhaps this?: diff --git a/include/Makefile.am b/include/Makefile.am
index 22819c8..feaaa60 100644
--- a/include/Makefile.am
+++ b/include/Makefile.am
@@ -17,6 +17,7 @@ noinst_HEADERS += compat/poll.h
noinst_HEADERS += compat/pthread.h
noinst_HEADERS += compat/readpassphrase.h
noinst_HEADERS += compat/resolv.h
+noinst_HEADERS += compat/stdint.h
noinst_HEADERS += compat/stdio.h
noinst_HEADERS += compat/stdlib.h
noinst_HEADERS += compat/string.h |
Ah, nice, thanks! That said |
On Wed, Jun 05, 2024 at 11:48:11AM -0700, Viktor Szakats wrote:
Perhaps this?:
Yes, that's it. Care to make this a PR?
|
There it is: #1065 |
Thanks. And this should indeed fix this warning. I'll double check and
revert the hack in chacha-merged.c
|
Hmm, this file has been here for 6 years and never made an appearance in the distributed tarballs. Darn, sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While skimming commits I noticed that the codebase does actually
tackle the case where OpenBSD-specific
__bound__
attribute isnot supported by the compiler. The logic was moved to
compat/stdint.h
in 3a75727 (2023-07-05),
but this header is missing from the tarball as of v3.9.2.
Would the presence of this header fix the GCC compiler warnings in
chacha-merged.c
mentioned here?:#910 (comment)
If so, I wonder if it'd be a good idea to add it to the tarball,
but could not.figure out the script responsible for this
The text was updated successfully, but these errors were encountered: