-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiler warnings with LibreSSL 3.7.3 (gcc 9, macOS, mingw-w64) #910
Comments
Reported by Viktor Szakats in libressl/portable#910 ok job
Tried fixing the export ac_cv_func_strtonum='no'
./configure [...] This fixes it running 1 on older macOS versions by forcing the local implementation.
Footnotes
|
Reported by Viktor Szakats in libressl/portable#910 ok job
Thanks for the report. Some notes.
This is an actual bug, fixed.
These come from portable/patches/windows_headers.patch Line 27 in 34f45b6
etc, so need to be fixed in this repo. If there is a better way to do this, @busterb will surely be willing to take a patch.
This is an annoying warning since mkstemp(3) is not a drop-in replacement. In particular, silencing this warning will need a bit of work. Since there is no actual issue, this is very low on the list of priorities. I'll defer to @busterb to figure out a fix for the strtonum issue. |
Thanks @botovq. Regarding The |
Sorry to extend this report here (and let me know if this should be a separate issue), I found this in my notes, this one is Windows-specific, and I'm building with
Ref: https://ci.appveyor.com/project/curlorg/curl-for-win/builds/47723913?fullLog=true#L4802 Also had this macro confusion while testing ASM (and no-ASM) with CMake:
|
Regarding OpenSSL silently #undefs the colliding symbols and defines BoringSSL doesn't #undef anything. Here's the summary of the macros undefined by LibreSSL:
wolfSSL also #undefs |
This comment was marked as outdated.
This comment was marked as outdated.
Further info for the no warnings, with -O3, 3.8.0: warnings, without -O3, 3.8.0: warnings, without -O3, 3.8.1: (not tested with other -O levels. Seen with llvm/clang-16, and this goes back many major releases.) No clue about the reasons. |
Another class of warnings that requires
edit: |
Thank you for the |
Fixes this warning when `OPENSSL_NO_ASM` is already set by the build system (seen with CMake): ``` In file included from ./libressl/crypto/bn/bn_mul.c:65: ./libressl/crypto/bn/arch/amd64/bn_arch.h:24:9: warning: 'OPENSSL_NO_ASM' macro redefined [-Wmacro-redefined] ^ <command line>:10:9: note: previous definition is here ^ ``` Reported in libressl#910
Pointed out in libressl#910
Pointed out in libressl#910
Pointed out in libressl#910
Besides the
|
gcc 9:
[FIXED libressl/openbsd@88b042a]
mingw-w64 llvm 16 when built against curl (8.2.1):
[FIXED]
Apple clang 14 autotools with -mmacosx-version-min=10.13:
[note: strtonum is detected by ./configure, despite passing -mmacosx-version-min=10.13]
The text was updated successfully, but these errors were encountered: