Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mop up #1084 breakage #1100

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Mop up #1084 breakage #1100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
415eb81
Revert "bump minimum CMake version for DLL_NAME_WITH_SOVERSION"
botovq Oct 2, 2024
6a20a58
Only use DLL_NAME_WITH_SOVERSION for cmake >= 3.27
botovq Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required (VERSION 3.27)
cmake_minimum_required (VERSION 3.16.4)
if(MSVC)
cmake_policy(SET CMP0091 NEW)
endif()
Expand Down
4 changes: 3 additions & 1 deletion crypto/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,7 +850,9 @@ set_target_properties(crypto PROPERTIES
EXPORT_NAME Crypto
VERSION ${CRYPTO_VERSION}
SOVERSION ${CRYPTO_MAJOR_VERSION}
DLL_NAME_WITH_SOVERSION TRUE
if(NOT CMAKE_VERSION VERSION_LESS 3.27.0)
DLL_NAME_WITH_SOVERSION TRUE
endif()
)

target_include_directories(
Expand Down
4 changes: 3 additions & 1 deletion ssl/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,9 @@ set_target_properties(ssl PROPERTIES
EXPORT_NAME SSL
VERSION ${SSL_VERSION}
SOVERSION ${SSL_MAJOR_VERSION}
DLL_NAME_WITH_SOVERSION TRUE
if(NOT CMAKE_VERSION VERSION_LESS 3.27.0)
DLL_NAME_WITH_SOVERSION TRUE
endif()
)

target_include_directories(
Expand Down
4 changes: 3 additions & 1 deletion tls/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ set_target_properties(tls PROPERTIES
EXPORT_NAME TLS
VERSION ${TLS_VERSION}
SOVERSION ${TLS_MAJOR_VERSION}
DLL_NAME_WITH_SOVERSION TRUE
if(NOT CMAKE_VERSION VERSION_LESS 3.27.0)
DLL_NAME_WITH_SOVERSION TRUE
endif()
)

target_include_directories(
Expand Down
Loading