-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable additional MSVC warnings #1124
Conversation
Attempting to land https://github.com/microsoft/vcpkg/blob/master/ports/libressl/0002-suppress-msvc-warnings.patch into this repository so I ran through the warnings generated for 4.0.0+ code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these are fine with me, but I would really like to see the output of a build that shows some of these warnings.
Edit: Never mind. I see them in our CI.
Can squash this whenever you're done with your review @botovq . Thanks for the speedy replies! |
I think I am done. The "'void' function returning a value" will be fixed upstream so it isn't needed. The potentially uninitialized and dead code warnings should only be set on the mentioned files, if it's not too much trouble. Feel free to squash and force push a new version. |
Append additional MSVC warnings to `MSVC_DISABLED_WARNINGS_LIST`. Disable warnings for specific files using `COMPILE_OPTIONS`.
042db23
to
1996dbc
Compare
Ok think I got everything @botovq If you all decide to do this in the code by pushing and popping warnings then you can drop all the |
Thanks. Pushing and popping warnings in a portable way is also ugly, so we'd need to carry patches. I think we're good with this solution for now. If it's getting too unwieldy we can reconsider. The last sync I just pushed also contains a fix for the 'void' function warning. |
Great thanks again @botovq ! |
Append additional MSVC warnings to
MSVC_DISABLED_WARNINGS_LIST
.