Hiscores not loading in some games

[eadmaster]

One of these games is mysticri.

I've found this is due to this check that rely on the game driver to specify if the hiscore is supported or not.

Since new games are added constantly to the MAME datfile maybe it is better to disable the check?

Related issue: #220

[eadmaster]

Another issue is this hard limit for the ranges.

There a few games in the current datfile with more than 20 ranges associated: boblbobl, bublboblp, cosmicg.

[barbudreadmon]

Duplicate of finalburnneo#378 , and no we can't remove that check : you can break hiscores when resetting if HiscoreReset isn't called appropriately for each game with enabled hiscore.
I didn't know about the range part, thanks for the heads-up, will look into this.

[eadmaster]

ok, so if i disable the check and call HiscoreReset() every time a game is reset it should be fine then?

[barbudreadmon]

yes

[eadmaster]

Fixed in my libretro-only branch by calling HiscoreReset() in retro_reset().
I'll monitor the other issue for a better solution.

[barbudreadmon]

well, no, you didn't fix anything, you should read the other issue...

[eadmaster]

I've just tried resetting the libretro core with an hiscore loaded multiple times, and my .hi file stays intact, so i guess this fixes the problem with the libretro port, at least...

[barbudreadmon]

As mentioned in the other issue, games can decide to reset themselves internally for various reasons, what you fixed is only manual reset. So that's not a fix, that's only a dirty hack that can only take care of the easy case.

[eadmaster]

Ok, i see your point now. I'm thinking another driver-agnostic solution now to detect a reset, i'll post in finalburnneo#378 after studying the code to see if it is doable.

[dinkc64]

dinkfucious say:
"It's best not to try to short-cut things, and do them the right way."