Add support for V2 Core Options and add option to set default controller. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ult controller as Left or Right.
msheehan79
changed the title
|
Hi @m4xw , I'd like to merge this unless you have any objections. |
|
@LibretroAdmin @m4xw any concerns with merging this PR? I have a few other changes in my dev branch I would like to submit if this can be merged (input bitmasks, and full keypad mapping instead of the On Screen Keypad, similar to the changes I submitted for the a5200 core) which should address #81 |
msheehan79
changed the title
|
Yes please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for V2 Core Options and adds one core option to set the default controller as either Left or Right.
The V2 options required an update to the libretro.h file so I updated the libretro-common dependencies as part of this.
Tagging as draft here as the prior attempt at this broke MSVC builds. I use MinGW here and it compiled fine for me, but I don't have an MSVC setup to verify this won't impact those builds again, so would appreciate any input or confirmation that it compiles OK for those setups.