Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONSULTATION NEEDED] Update input-controller-drivers.md: Updated the "Linux Controller Drivers" section #982

Merged
merged 4 commits into from
Nov 24, 2024

Conversation

davidhedlund
Copy link
Contributor

@davidhedlund davidhedlund commented Sep 3, 2024

Not documented yet:

Please document the following controller drivers in this PR before we approve it:

Added "parport"

Available for RetroArch in the Flatpak, AppImage, or APT package formats.

Removed "hid"

Found via sudo apt-get install retroarch in Ubuntu MATE 22.04 but it's broken.[1] Not found in Ubuntu MATE 23.04 or 24.04. "hid" is not found in the Flatpak or AppImage packages.

Perhaps it is utilized by other distros? Can anyone else please confirm that it should be removed from the "Linux Controller Drivers" section?

I didn't remove "hid" from https://docs.libretro.com/guides/input-controller-drivers/#windows

1: a) Change the controller driver b) Restart RetroArch for the Setting to take effect. c) Settings -> Input -> Input User 1 Binds -> User 1 Bind All

Removed "xinput"

A proprietary controller driver developed by Microsoft not available for RetroArch in the Flatpak, AppImage, or APT package formats.

Can anyone else please confirm that it should be removed from the "Linux Controller Drivers" section?

I didn't remove "xinput" from https://docs.libretro.com/guides/input-controller-drivers/#windows

…roller Drivers section

The proprietary "xinput" controller driver developed by Microsoft has been removed from the "Linux Controller Drivers" section because it is not available for Flatpak, AppImage, or APT package formats.
Added parport to the "Linux Controller Drivers" section
@davidhedlund davidhedlund changed the title Update input-controller-drivers.md: Removal of xinput from Linux Controller Drivers section Update input-controller-drivers.md: Updated the entries in the "Linux Controller Drivers" section Sep 3, 2024
removed "hid" from the "Linux Controller Drivers" section
@davidhedlund davidhedlund marked this pull request as ready for review September 3, 2024 01:18
@davidhedlund davidhedlund changed the title Update input-controller-drivers.md: Updated the entries in the "Linux Controller Drivers" section Update input-controller-drivers.md: Updated the "Linux Controller Drivers" section Sep 3, 2024
@davidhedlund davidhedlund changed the title Update input-controller-drivers.md: Updated the "Linux Controller Drivers" section [CONSULTATION NEEDED] Update input-controller-drivers.md: Updated the "Linux Controller Drivers" section Sep 6, 2024
@landfillbaby
Copy link
Contributor

landfillbaby commented Sep 22, 2024

According to configuration.c and input/drivers/x11_input.c, the x driver is the X11 input driver.
Either there's a few things left over from back when the joypad and input drivers were a single setting, or there's something I've missed and it actually does use those 2 autoconfig files somehow... @RobLoach can you remember why you created those 2 files 7 years ago?

input/input_driver.c says hid is on any platform with libusb and threading, so Linux definitely has it.

There are actually at least 5 different XInput drivers for Linux: xboxdrv, xpad, xpadneo, xow, and xone.
They're all accessed via udev though, so I think it's right to remove the xinput driver, yes.

documented MFI, and QNX
@RobLoach
Copy link
Member

No recollection 🫠

@RobLoach
Copy link
Member

Anything that needs to be renamed/moved in auto config?

@LibretroAdmin
Copy link
Contributor

I'm going to assume this can be merged without further delay.

If anything more needs to be done, send a new PR.

@LibretroAdmin LibretroAdmin merged commit f38ee1b into libretro:master Nov 24, 2024
@davidhedlund
Copy link
Contributor Author

davidhedlund commented Nov 24, 2024

input/input_driver.c says hid is on any platform with libusb and threading, so Linux definitely has it.

Should I restore "hid" for GNU/Linux (please see the changes)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants