Feature/lxl 4610 allow dead links in bulk change spec #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
olovy
reviewed
Feb 25, 2025
olovy
reviewed
Feb 25, 2025
olovy
reviewed
Feb 25, 2025
whelk-core/src/main/groovy/whelk/component/PostgreSQLComponent.groovy
Outdated
Show resolved
Hide resolved
olovy
reviewed
Feb 25, 2025
whelktool/src/main/groovy/whelk/datatool/form/ModifiedThing.groovy
Outdated
Show resolved
Hide resolved
olovy
reviewed
Feb 25, 2025
whelk-core/src/main/groovy/whelk/component/PostgreSQLComponent.groovy
Outdated
Show resolved
Hide resolved
olovy
reviewed
Feb 25, 2025
whelk-core/src/main/groovy/whelk/component/PostgreSQLComponent.groovy
Outdated
Show resolved
Hide resolved
kwahlin
force-pushed
the
feature/lxl-4610-allow-dead-links-in-bulk-changeSpec
branch
from
758c7fb to
1b22ecd
Compare
olovy
reviewed
Feb 25, 2025
| } | ||
| if (data instanceof Map) { | ||
| // Keep original ID for "weak relations" | ||
| if (isLink(data) && !JsonLd.isWeak(propertyPath.join("."))) { |
There was a problem hiding this comment.
Will not return here if it is weak link.
i.e. the loop below will be run for weak links
olovy
reviewed
Feb 25, 2025
olovy
requested changes
Feb 25, 2025
kwahlin
force-pushed
the
feature/lxl-4610-allow-dead-links-in-bulk-changeSpec
branch
from
1b22ecd to
55e5f1a
Compare
- Prevent new links to deleted resources within XL from ever being created, sameAs excepted. - Records may, in general, not be deleted if they are referenced by other records. - Declare some relations as "weak". A record may be deleted if only referenced by these relations. - For weak relations, keep original ID on normalization. - Refactor and clean up
kwahlin
force-pushed
the
feature/lxl-4610-allow-dead-links-in-bulk-changeSpec
branch
from
55e5f1a to
a6e9053
Compare
olovy
deleted the
feature/lxl-4610-allow-dead-links-in-bulk-changeSpec
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to delete records referenced in a bulk change specification, allow any property inside a
bulk:ChangeSpec(i.e. the object ofbulk:changeSpecto hold links to deleted resources. We already have a similar mechanism for exact paths, seelibrisxl/whelk-core/src/main/groovy/whelk/JsonLd.groovy
Line 59 in a56f059
This should not however be hardcoded but rather defined in the vocab (TODO).
See https://kbse.atlassian.net/browse/LXL-4610 for more info.
I sneaked in another commit too (a56f059) that is unrelated to the above. When the data in a record is not compatible with the operations specified in a
bulk:ChangeSpecof abulk:Update, the record is just ignored and won't be affected by the job. This can happen for example when trying to add another value to a property that is not repeatable.