Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(supersearch): Add persistent item support (LWS-289) #1205

Merged
merged 6 commits into from
Jan 20, 2025

Conversation

johanbissemattsson
Copy link
Contributor

@johanbissemattsson johanbissemattsson commented Jan 17, 2025

Description

Tickets involved

LWS-289

Solves

Add persistent item support (shown before fetched result items).

Summary of changes

  • Add persistent item support
  • Use default testid naming convention
  • Rename id and class name of suggestion items
  • Update readme

@johanbissemattsson johanbissemattsson changed the title feat(supersearch): Add leading persistent row support(LWS-289) feat(supersearch): Add persistent item support(LWS-289) Jan 17, 2025
@johanbissemattsson johanbissemattsson changed the title feat(supersearch): Add persistent item support(LWS-289) feat(supersearch): Add persistent item support (LWS-289) Jan 17, 2025
@johanbissemattsson johanbissemattsson marked this pull request as ready for review January 17, 2025 20:12
Copy link
Contributor

@jesperengstrom jesperengstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌟

@johanbissemattsson johanbissemattsson merged commit be8ef7b into develop Jan 20, 2025
3 checks passed
@johanbissemattsson johanbissemattsson deleted the feat/supersearch-leading-persitent-row branch January 20, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants