-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lxlweb): Decorated suggestions (LWS-321) #1210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! 🖼️
We should improve handling of instances but that is a separate issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🙌
I think the focus when doing a more final version should be to make the result items as small as possible (while still being usable/accessible) due to the limited space available. This is even more cruical on mobile devices as there will also often be a keyboard occupying space underneath.
See attached screenshot where I tried removing the borders and changing the max-height to 56px instead of 72px (we could probably make it even smaller if we adjust the font sizes):
It can also affect the choice of number of results to show (I think fewer is better to avoid information overload).
I'm all for that, considering the menu will have more stuff (search history etc) we have to be able to fit everything. If you still have the code changes you're welcome to push :) |
👍 I made some minor styling adjustments in 535554e |
Description
Tickets involved
LWS-321
Solves
Adds decorated data to supersearch suggestions in the form of a
SuggestCard
component, basically a slimmed version ofSearchCard
. Now also fetching results for Work, Agent, Concept & Language types.As a result of new types showing up, the web-card lenses needed adjustment. I chose a minimal approach, see examples below.
We also need to tweak relevance between types; a search for 'Mikael Yvesand' returns the Person as the last result.
Upgraded Svelte to be able to use the new more flexible class array syntax.
Summary of changes
SuggestionCard
SearchCard
getInstanceData
function into utils file and add tests