Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from roles to role #1987

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Update from roles to role #1987

merged 1 commit into from
Mar 3, 2024

Conversation

chartgerink
Copy link
Member

This PR updates the roles element of the user data to role. It appears that BlitzJS only validates against the role and therefore was having issues allowing people with the right permissions to access restricted pages (e.g., /admin but also the membership area).

Fixes #1958.

@chartgerink chartgerink requested a review from nsunami as a code owner March 1, 2024 09:36
@chartgerink chartgerink temporarily deployed to researchequa-fix-1958-4rmj8hvh March 1, 2024 09:36 Inactive
Copy link
Collaborator

@nsunami nsunami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
I tested setting myself as a SUPERADMIN, and I was able to access the admin dashboard.

I had one additional comment about the prettier config for disabling trailing space.

@chartgerink chartgerink merged commit a5dac73 into main Mar 3, 2024
2 checks passed
@chartgerink chartgerink deleted the fix/1958 branch March 3, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Role based routing permissions not working
2 participants