Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Make SDL_AppQuit aware of SDL_AppResult #10994

Closed
AntTheAlchemist opened this issue Sep 29, 2024 · 2 comments · Fixed by #11000
Closed

Feature request: Make SDL_AppQuit aware of SDL_AppResult #10994

AntTheAlchemist opened this issue Sep 29, 2024 · 2 comments · Fixed by #11000
Milestone
3.0 ABI

Comments

@AntTheAlchemist
Copy link
Contributor

Is it a good idea to pass SDL_AppResult to SDL_AppQuit, so it knows under what condition the app was terminated. For example, a decision can be made about saving settings depending on if the app shut down due to a failure.
@slouken slouken added this to the 3.0 ABI milestone Sep 29, 2024
@slouken
Copy link
Collaborator

slouken commented Sep 29, 2024

Interesting idea. @icculus?

icculus added a commit to icculus/SDL that referenced this issue Sep 30, 2024
@icculus
main: SDL_AppQuit() now reports the result value.
912ad6d 
Fixes libsdl-org#10994.
@icculus icculus mentioned this issue Sep 30, 2024
Merged
@icculus
Copy link
Collaborator

icculus commented Sep 30, 2024

I just put up a PR for this; if you like it, click merge!

icculus added a commit to icculus/SDL that referenced this issue Sep 30, 2024
@icculus
main: SDL_AppQuit() now reports the result value.
e6ed45b 
Fixes libsdl-org#10994.
klukaszek pushed a commit to klukaszek/SDL that referenced this issue Oct 2, 2024
@icculus @klukaszek
main: SDL_AppQuit() now reports the result value.
fe0d8c2 
Fixes libsdl-org#10994.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0 ABI
Development

Successfully merging a pull request may close this issue.

main: SDL_AppQuit() now reports the result value. icculus/SDL
3 participants
@icculus @slouken @AntTheAlchemist