Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDL2 Vita] Wrong touch IDs gets assigned to touch devices #9830

Closed
Wohlstand opened this issue May 18, 2024 · 5 comments
Closed

[SDL2 Vita] Wrong touch IDs gets assigned to touch devices #9830

Wohlstand opened this issue May 18, 2024 · 5 comments
Milestone
2.32.0

Comments

@Wohlstand
Copy link
Contributor

Hello!

I do see that at the SDL2 touch device IDs gets assigned incorrectly: one of IDs had been assigned as 0 that results an invalid behaviour: the SDL_GetTouchDevice() claims the 0 is an invalid device, but in a case of Vita's code it's a fully valid device.

Anyway, on SDL3 side I see these device ID codes are valid.
@slouken
Copy link
Collaborator

slouken commented May 18, 2024

Please feel free to submit a PR to fix this, thanks!

@slouken slouken added this to the 2.32.0 milestone May 18, 2024
@Wohlstand
Copy link
Contributor Author

I'll do, but right now I'm out of home, first off I should test out this on my end. I'll be back when I get my home.

@Wohlstand
Copy link
Contributor Author

Wohlstand commented Aug 14, 2024 •
edited
Loading

Hello!
Sorry for the VERY long delay, I was:

  • busy
  • ill
  • overloaded
  • etc.

Now, I going to perform this. Actually very small tweak, just few digits, so long time of wait...

@Wohlstand Wohlstand mentioned this issue Aug 14, 2024
Merged
@Wohlstand
Copy link
Contributor Author

Wohlstand commented Aug 14, 2024 •
edited
Loading

@slouken, is possible that change I did will come into the next bugfix update? Or you already going to release the 2.32.0 very soon? I asking because of milestone where this task is. It's solved right now.
Now going to close it, and then try to resolve the new renderer bug (#10538) that ruined my test of this.

@slouken
Copy link
Collaborator

slouken commented Aug 14, 2024

Yes, I've merged it to release-2.30.x so it'll be in the next 2.30 release.

Wohlstand referenced this issue Jan 1, 2025
@Wohlstand @slouken
SDL_vitatouch.c: Fixed the incorrect touch device IDs
847a6cc 
- Begining of device ID with 0 violates the SDL's specification that means the 0 is an error, invalid, failure, etc. But on Vita here it's an actual device...
- Replacing 0 and 1 with 1 and 2 to resolve this violation.

(cherry picked from commit dd6c663)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.32.0
Development

No branches or pull requests
2 participants
@slouken @Wohlstand