Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the incorrect touch device IDs on the Vita #10537

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

Wohlstand
Copy link
Contributor

@Wohlstand Wohlstand commented Aug 14, 2024

NOTE: I am in process of local testing of the thing, I will turn this into ready-to-merge PR once I confirm the thing works on my end perfectly. I found another bug, going to report it separately, This one let's just merge.

Description

  • Begining of device ID with 0 violates the SDL's specification that means the 0 is an error, invalid, failure, etc. But on Vita here it's an actual device...
  • Replacing 0 and 1 with 1 and 2 to resolve this violation.

Existing Issue(s)

#9830

- Begining of device ID with 0 violates the SDL's specification that means the 0 is an error, invalid, failure, etc. But on Vita here it's an actual device...
- Replacing 0 and 1 with 1 and 2 to resolve this violation.
@Wohlstand
Copy link
Contributor Author

Actualy... I found another bug, so I going to report it. But this let's just merge.

@Wohlstand Wohlstand marked this pull request as ready for review August 14, 2024 01:30
@slouken slouken merged commit dd6c663 into libsdl-org:SDL2 Aug 14, 2024
38 checks passed
@slouken
Copy link
Collaborator

slouken commented Aug 14, 2024

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants