Incorrect bfOffBits Calculation in WIN_ConvertDIBtoBMP #12315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
WIN_ConvertDIBtoBMP, the code incorrectly usessizeof(BITMAPINFOHEADER)instead ofpbih->biSizeto calculate the offset to pixel data in the BMP header. This leads to invalid BMP files when the DIB uses a header larger than BITMAPINFOHEADER.Solution
Replaced
sizeof(BITMAPINFOHEADER)withpbih->biSizeas it represents the actual size of the DIB header (e.g., 40, 108 bytes), ensuring the correct offset to pixel data.