Detect device form factor #12584
Open
Detect device form factor #12584
+182
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zturtleman
reviewed
Mar 19, 2025
madebr
reviewed
Mar 19, 2025
android-project/app/src/main/java/org/libsdl/app/SDLActivity.java
Outdated
Show resolved
Hide resolved
Semphriss
force-pushed
the
form-factor
branch
3 times, most recently
from
4255201 to
bd739df
Compare
|
|
|
@TheMode I'm not sure how translation would be supported, but I can give it a try. I'll see if there's another similar function in SDL to use as a template. Edit: I've given it a quick look, and it seems that most functions promising a "human readable" string either returns a string generated by something outside SDL (like a camera device name) or the literal stringification of an enum (like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new function
SDL_GetDeviceFormFactor(), which guesses what kind of device the current device may be.It can report the following devices:
I've added support to the best of my abilities, but I couldn't cover 100% of cases either because I'm not familiar enough with the platform (QNX can be in phones, cars, and other embedded systems) or because the system itself doesn't provide that information (generic Unix).
I'm also aware that private platforms may want to provide their own value, but I couldn't find a compiler macro that detects if SDL is currently being compiled for a private platform. I would need help to find out how that can be done.
Existing Issue(s)
None