-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[SDL3] [PS2] Framebuffer resolution + 240p/480p + PAL support #13993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Allows for switching between NTSC/PAL, progressive/interlaced, etc
slouken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good. I made some SDL-style changes, can you check and see if they look good to you?
Co-authored-by: Sam Lantinga <slouken@libsdl.org>
|
Looks good to me. |
|
Merged, thanks! In general we are just making changes like this in SDL3. Is there a reason you can't use that for your project and need the SDL2 PR? |
…-org#13993) * Do not override NTSC/PAL * Fix PS2 build instructions * Add PS2 GS hints Allows for switching between NTSC/PAL, progressive/interlaced, etc
|
@slouken This isn't a breaking change, unless you expect a PAL PS2 to output an NTSC signal, which it won't even do in OSDSYS (the browser). -- By default, the framebuffer assumes the resolution of the smaller NTSC signal (448px), regardless of region, just as before. It is simply centered on a PAL console. Pre-existing games should work absolutely fine. |
* Do not override NTSC/PAL * Fix PS2 build instructions * Add PS2 GS hints Allows for switching between NTSC/PAL, progressive/interlaced, etc (cherry picked from commit 3fd0b46)
|
Okay, I've cherry-picked the changes for the next SDL2 release. |
…-org#13993) * Do not override NTSC/PAL * Fix PS2 build instructions * Add PS2 GS hints Allows for switching between NTSC/PAL, progressive/interlaced, etc
I've been wanting to use the lowres 240p mode on PS2 as I like to do software rendering, and the CPU is somewhat weak. These changes allow for that.
Description
This adds the special hints:
SDL_HINT_PS2_GS_WIDTH,SDL_HINT_PS2_GS_HEIGHT,SDL_HINT_PS2_GS_PROGRESSIVE,SDL_HINT_PS2_GS_MODEThey allow for the framebuffer width and height to be set, progressive to be turned on/off and to decide which regional format to use for the signal (PAL/NTSC). Furthermore, the region is no longer overridden by default, so the console will use its native region, instead of NTSC.
Existing Issue(s)
ps2dev/ps2sdk-ports#183
#13969