Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build tests for all CMake platforms on CI #5637

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

ccawley2011
Copy link
Contributor

@ccawley2011 ccawley2011 commented May 8, 2022

This is currently a draft because some tests aren't building properly with Emscripten and I'm not sure how to fix it.

Includes changes from #5635 and #5636. See also issue #5634.

@madebr
Copy link
Contributor

madebr commented Jun 3, 2022

FYI, I"m also having an issue with building an emscripten test application in #5727

error: undefined symbol: emscripten_sync_run_in_main_runtime_thread_

I disabled building an emscripten application in the aforementioned pr.

@slouken
Copy link
Collaborator

slouken commented Jun 3, 2022

Let's go ahead and disable the emscritpen test, and enter an issue to take care of that later.

@ccawley2011, go ahead and make the replacement of the clock functions the default path, without any Vita checks.

@ccawley2011
Copy link
Contributor Author

@ccawley2011, go ahead and make the replacement of the clock functions the default path, without any Vita checks.

OK, done.

@ccawley2011 ccawley2011 marked this pull request as ready for review June 11, 2022 17:19
@slouken slouken merged commit 12f9bcd into libsdl-org:main Jun 15, 2022
@ccawley2011 ccawley2011 deleted the cmake-test-ci branch June 15, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants