Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] JPEG: Handle errors when saving with libjpeg #432

Merged
merged 2 commits into from
Mar 11, 2024
Merged

[2.x] JPEG: Handle errors when saving with libjpeg #432

merged 2 commits into from
Mar 11, 2024

Commits on Mar 11, 2024

  1. JPEG: Factor out the middle of IMG_SaveJPG_RW_jpeglib 

    No functional change intended. We'll need to use setjmp() in this
function in a subsequent commit, so ensure that its state doesn't
include any local variables that are used both "above" and "below"
the stack level at which we will call setjmp().

Signed-off-by: Simon McVittie <smcv@collabora.com>
    @smcv
    smcv committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    e5b3ef1 View commit details
    Browse the repository at this point in the history

  2. JPEG: Add error-recovery when saving with libjpeg 

    Because we have set up libjpeg to use my_error_exit, we need to call
setjmp() before the first time it might possibly call longjmp().
Otherwise, on error we'll do a non-local goto to an uninitialized
pointer and crash.

Resolves: libsdl-org#429
Signed-off-by: Simon McVittie <smcv@collabora.com>
    @smcv
    smcv committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    b0c271c View commit details
    Browse the repository at this point in the history