Add seek, tell, and duration to fluidsynth #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that when playing a track it starts from the beginning.
|
The change cherry-picks cleanly onto main if you prefer. I am working with sdl2 so I targeted that branch. |
|
Please create a PR for sdl3 as well. |
|
Merged and cherry-picked to main, thanks! |
|
The tick functions are actually available since v1.1.7: should we still restrict them to builds against v2.0? |
|
Both those releases were in 2018, I'm not sure it's worth the extra condition? |
sezero
added a commit
that referenced
this pull request
Jun 3, 2023
sezero
added a commit
that referenced
this pull request
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that when playing a track it starts from the beginning.
Fixes #519