Add PropertiesID field to Metadata structs #96
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not much to see here, except one detail: The rest of the metadata struct does not have to be initialized since it's mostly an out struct, but the only way Properties will work here is if that one field is initialized first. The idea is that shadercross would check
props
for known metadata extensions, then fill in the properties found when applicable.Kind of weird but it does work - if we still don't want to do this we can just call this
WONTFIX
.Fixes #72