Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PropertiesID field to Metadata structs #96

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

flibitijibibo
Copy link
Collaborator

Not much to see here, except one detail: The rest of the metadata struct does not have to be initialized since it's mostly an out struct, but the only way Properties will work here is if that one field is initialized first. The idea is that shadercross would check props for known metadata extensions, then fill in the properties found when applicable.

Kind of weird but it does work - if we still don't want to do this we can just call this WONTFIX.

Fixes #72

@thatcosmonaut
Copy link
Collaborator

Maybe we should note on the out structs that the client has to free the properties if they are not 0.

@flibitijibibo
Copy link
Collaborator Author

Tweaked the docs accordingly.

@flibitijibibo flibitijibibo merged commit a1bc850 into libsdl-org:main Jan 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should the Metadata structs have a Properties field?
2 participants