Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Songlength Database path should be within $HOME, not the install prefix #35

Closed
multiplealiases opened this issue Apr 2, 2024 · 0 comments
Assignees
Milestone

Comments

@multiplealiases
Copy link

On Unix-likes, the default path that sidplayfp looks for a Songlengths.txt is $PREFIX/share/sidplay/Songlengths.txt, so on a "typical" Unix-like system, this would be something like /usr/share/sidplayfp/Songlengths.txt.

I feel this is a weird default, since

  • By convention and by FHS, everything under /usr is typically the package manager's job to manage. The administrator is not meant to poke around under there manually.
  • No Linux distribution I checked (Debian, Ubuntu, Fedora, OpenSuSE) that packages sidplayfp places a Songlengths.txt (or .md5, for that matter) in /usr/share/sidplayfp, so the default path is essentially useless. The user is forced to edit sidplayfp.ini to have it point to a convenient location, or worse, to (attempt to) copy a file into a directory that could very well be read-only for the current user.

What I would like to suggest instead is the following:

  • Follow precedent established by the Kernal, Basic, and Chargen ROMs by searching for either $XDG_DATA_HOME/sidplayfp/Songlengths.txt or $HOME/.local/share/sidplayfp/Songlengths.txt. This makes it so that the user can easily install the database without poking around in essential system files.
  • Display a warning if the Songlength Database option in sidplayfp.ini is unset and there is no Songlengths.txt in the default location. As it stands, the only indication that the Songlength DB is absent is that every SID file displays an UNKNOWN length.
@drfiemost drfiemost self-assigned this Apr 5, 2024
@drfiemost drfiemost added this to the 2.8 milestone Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants