Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note detection off by a semitone when forcing PAL/NTSC signal via command line #37

Closed
ruby-R53 opened this issue Jul 2, 2024 · 2 comments
Closed

Note detection off by a semitone when forcing PAL/NTSC signal via command line #37

ruby-R53 opened this issue Jul 2, 2024 · 2 comments
Assignees
@drfiemost

Comments

@ruby-R53
Copy link
Contributor

ruby-R53 commented Jul 2, 2024 •
edited
Loading

When using either -vnf or -vpf, sidplayfp still uses the frequency table specified by the tune to display the notes, and that makes the note display off by one semitone.

I tried fixing it by editing args.cpp and repointing m_freqTable to freqTablePal/freqTableNtsc when -vpf/-vnf is used but I couldn't.

I'm using sidplayfp's latest release.
@drfiemost drfiemost self-assigned this Jul 4, 2024
drfiemost added a commit that referenced this issue Jul 5, 2024
@drfiemost
USe correct freq table when using custom speed (#37)
99d29c9
@drfiemost
Copy link
Member

Should be fixed in master, can you please check?

@ruby-R53
Copy link
Contributor Author

ruby-R53 commented Jul 5, 2024

it's working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drfiemost drfiemost

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drfiemost @ruby-R53