Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for muting samples #5

Closed
minttukone opened this issue May 31, 2021 · 4 comments · Fixed by #45
Closed

Support for muting samples #5

minttukone opened this issue May 31, 2021 · 4 comments · Fixed by #45
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@minttukone
Copy link

I use sidplayfp for splitting SID files into individual channels, and it works fine for songs that don't use digisamples, but when I have to split songs that have digisamples, although sidplayfp plays the digisamples properly, you need to patch the SID file to do so. Maybe there is an option to mute samples, but I haven't found one yet.
This is roughly why it would be great to see a feature in sidplayfp to mute samples.

@drfiemost
Copy link
Member

Samples are not a feature but a side effect, also there are different techniques for playing digis. I don't see an obvious way to mute them, maybe some sort of digiboost could help for volume register based samples on 6581, but overall I don't see a reliable solution to this request.

@drfiemost drfiemost added the enhancement New feature or request label Jun 4, 2021
@LManMusic
Copy link

A flag that disables all writes to the $D418 volume register would disable the traditional sample playback, and solve this problem. Bonus points for isolating the samples by interpreting only the volume register noises,

@drfiemost
Copy link
Member

I guess you mean only the low nibble of $D418? Interesting trick, will give it a spin and maybe put it in the TODO list for the lib.

@acrouzet
Copy link
Contributor

A flag that disables all writes to the $D418 volume register would disable the traditional sample playback, and solve this problem. Bonus points for isolating the samples by interpreting only the volume register noises,

Sample isolation can currently be achieved by simply muting all the channels. The problem is that since the samples affect the volume, cancellation of the samples via inversion will still leave very audible (and visible) artifacts.

@drfiemost drfiemost self-assigned this Sep 15, 2024
@drfiemost drfiemost added this to the 2.10 milestone Sep 15, 2024
drfiemost added a commit that referenced this issue Sep 15, 2024
@drfiemost drfiemost linked a pull request Sep 15, 2024 that will close this issue
drfiemost added a commit that referenced this issue Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants