Use a separate thread to update the display (#57) #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drfiemost
changed the title
|
not sure if you're aware but it seems like the display doesn't get updated enough here, it gets quite noticeable with tunes that switch waveforms very fast like Jeroen Tel's which's weird considering the display updates every 16 or 20 ms, to correspond to 60 and 50 Hz··· and lowering that refresh rate just makes the screen flicker more while still not updating the information properly |
drfiemost
force-pushed
the
display_thread
branch
from
17d4c04 to
c68b777
Compare
|
Yeah, it seems like updates happen in bursts, have no clue why... |
drfiemost
force-pushed
the
display_thread
branch
from
674dd1c to
71a00d8
Compare
|
Oh wait, the problem is that the audio writes are blocking so there is no update to the emulation while buffers are played back. So we are still limited by the buffer size. If you try with -w you can see the display is very quick. |
|
yeah that's what i was guessing x) |
drfiemost
force-pushed
the
display_thread
branch
2 times, most recently
from
4ed9276 to
e9dd44a
Compare
drfiemost
force-pushed
the
display_thread
branch
from
f04f8da to
7abc1d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.