This repository was archived by the owner on Oct 18, 2023. It is now read-only.
Asynchronous snapshot upload #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psarna
suggested changes
Aug 11, 2023
|
I'm on vacation next two weeks, so just to keep priorities straight - either this PR, or #547, need to be applied, so that we're 100% sure we don't have autocheckpoint enabled on connections, and only control the checkpoints ourselves. More importantly, in the fiber that performs the checkpoint, we need to make sure that it's performed from a connection that has our custom WAL methods registered, so that we call the sqld/sqld/src/replication/primary/logger.rs Line 171 in bb27f19 |
Horusiath
force-pushed
the
bart/async-snapshot-upload
branch
from
a20241f to
5ae39a2
Compare
Horusiath
force-pushed
the
bart/async-snapshot-upload
branch
from
afc814a to
eac46d2
Compare
haaawk
reviewed
Aug 29, 2023
haaawk
approved these changes
Aug 29, 2023
Horusiath
force-pushed
the
bart/async-snapshot-upload
branch
from
eac46d2 to
495d77c
Compare
Horusiath
force-pushed
the
bart/async-snapshot-upload
branch
from
495d77c to
c9126e1
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build on top of #547
This PR introduces async DB file snapshotting. Basically when checkpoint happens, we trigger asynchronous DB file backup. If the next checkpoint happens, it first waits until previous snapshot upload completes before continuing.