This repository was archived by the owner on Oct 18, 2023. It is now read-only.
fix rpc http connector #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
force-pushed
the
fix-rpc-http-connector
branch
3 times, most recently
from
64f1928 to
98febc3
Compare
MarinPostma
force-pushed
the
fix-rpc-http-connector
branch
from
34b3eed to
082ba41
Compare
LucioFranco
reviewed
Sep 15, 2023
| hyper::server::Server::builder(acceptor) | ||
| .serve(h2c) | ||
| .await | ||
| .context("http server")?; |
There was a problem hiding this comment.
Is this context gonna hide the error lol? Same with the one below?
There was a problem hiding this comment.
it's ok, this one is a top-level error, it will show up on the console
LucioFranco
approved these changes
Sep 15, 2023
MarinPostma
force-pushed
the
fix-rpc-http-connector
branch
from
082ba41 to
f5454e3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tls was misconfigured for the server after the networking refactor.
I needed to patch
hyper_rustlsto do that, so I have opened a PR there: rustls/hyper-rustls#221