This repository was archived by the owner on Oct 18, 2023. It is now read-only.
flush frames and confirm snapshot completion before calling SQLite checkpoint #704
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the issue when SQLite files (DB + WAL) are being modified before we confirm that they were backed up.
PS: don't merge yet, there's still an ongoing issue with tokio task never being scheduled causing a deadlock on subsequent checkpoints:
sqld/bottomless/src/replicator.rs
Lines 751 to 789 in dcb5840