-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/tx fees #42
Merged
Merged
Feat/tx fees #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cater for dust limits and adding more tests
…nd adjusting calcs to avoid an overflow
…atly, fees now call this to get tx bytes breakdown
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
==========================================
- Coverage 86.31% 86.10% -0.21%
==========================================
Files 26 26
Lines 2762 2800 +38
==========================================
+ Hits 2384 2411 +27
- Misses 260 268 +8
- Partials 118 121 +3
Continue to review full report at Codecov.
|
…rry about the size bool, instead they can call SizeUnsigned and Size
removed unneccesarily returnederrors
this is to be used on the receiving end of a tx/payment
jadwahab
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the fee calculations to improve accuracy and also provide a breakdown of the fees paid and the breakdown of the tx bytes.
This also includes some improvements to change calcs, change will now not be added if it will be below the dust limit after covering outputs and tx fees.
New methods added to the tx: