Skip to content

Commit

Permalink
fixup! add autotools tarball support
Browse files Browse the repository at this point in the history
  • Loading branch information
vtjnash committed Aug 24, 2021
1 parent 4abd4c0 commit 68f1f76
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 9 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ Command line utility for creating new releases of libuv.

1. Make sure you have the most up-to-date version of this tool and the libuv
branch that will be used to create the release.
2. Currently, the release tool requires Node.js v12.10.x. You may want to use
something like `nvm` to change Node versions.
2. Currently, the release tool requires Node.js v12 or later. You may want to
use something like `nvm` to change Node versions.
3. Run `node ./release.js --version x.x.x --dir path --remote name`, where
`x.x.x` is the version of libuv you are creating, `path` is the location of
the libuv core repository on your machine, and `name` is the libuv core git
Expand Down
10 changes: 3 additions & 7 deletions release.js
Original file line number Diff line number Diff line change
Expand Up @@ -402,15 +402,11 @@ function createCMakeTarBall() {

function createAutotoolsTarBall() {
var tag = ver.format(state.releaseVersion);
try {
var distver = format('%d.%d.%d',
state.releaseVersion.major,
state.releaseVersion.minor,
state.releaseVersion.patch);
} catch (err) {
return pauseRetry(err);
}
child_process.execFile('./autogen.sh', [], { stdio: 'inherit', cwd: dir},
child_process.execFile('./autogen.sh', [], { stdio: 'inherit', cwd: dir },
function(err, stdout, stderr) {
if (err) {
console.log(stdout);
Expand All @@ -424,7 +420,7 @@ function createAutotoolsTarBall() {
return pauseRetry(err);
}
child_process.execFile(dir + '/configure', [],
{ stdio: 'inherit', cwd: builddir},
{ stdio: 'inherit', cwd: builddir },
function(err, stdout, stderr) {
if (err) {
console.log(stdout);
Expand All @@ -443,7 +439,7 @@ function createAutotoolsTarBall() {
var dstfilename = path.join(dir, 'dist', format('libuv-%s-dist.tar.gz', tag));
try {
fs.renameSync(srcfilename, dstfilename);
fs.rmdirSync(builddir, { recursive: true });
fs.rmdirSync(builddir, { recursive: true }); // in future nodejs, this will be called rmSync
} catch (err) {
return pauseRetry(err);
}
Expand Down

0 comments on commit 68f1f76

Please sign in to comment.