win,errors: remap ERROR_ACCESS_DENIED to UV_EACCES

[RaisinTen]

If we try to use uv_fs_rmdir on a read-only directory on Windows, it
internally calls _wrmdir, which sets _doserrno to ERROR_ACCESS_DENIED
and errno to EACCES. However, ERROR_ACCESS_DENIED is mapped to UV_EPERM,
so I believe it should be remapped to UV_EACCES.

Signed-off-by: Darshan Sen raisinten@gmail.com

[RaisinTen]

Also, question: Why are we using _doserrno error values instead of using errno values directly if we are mapping them to errno error values prefixed with a UV_?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[RaisinTen]

cc @vtjnash can this get a review plz? CI is green

[vtjnash]

Would this end up changing anything else, such as uv_chmod (which calls NtSetInformationFile)?

[RaisinTen]

Would this end up changing anything else, such as uv_chmod (which calls NtSetInformationFile)?

@vtjnash I don't know of a way to cause an EPERM or an EACCES using chmod on Windows but yea, this would probably fix few other error codes as well.

[vtjnash]

For example, what result do you get if you try to chmod C:\\Windows?

[RaisinTen]

For example, what result do you get if you try to chmod C:\\Windows?

@vtjnash I tried running https://github.com/RaisinTen/tests/blob/3abee9e7a2344e450eaa1715dd89718a31abde66/test.js and it seems to work with no errors: https://github.com/RaisinTen/tests/runs/4060722205?check_suite_focus=true

[stale]

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.