Get Travis to build for iojs as well #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem with node-gyp not working with iojs can be solved by using the version shipped with iojs, not the version from the latest npm we install separately. See nodejs/node#433 for details. So we update npm to latest upstream only for old versions of node.js, not for the current version or for iojs.
Compiling against io.js 3.0.0 yields tons of errors with v8.h.
defunctzombie
added a commit
that referenced
this pull request
Aug 5, 2015
travis: test on iojs as well
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do you want Travis to build against io.js?
The problem with
node-gypnot working with iojs can be solved by using the version shipped with iojs, not the version from the latest npm we install separately. See nodejs/node#433 for details. So we update npm to latest upstream only for old versions of node.js, not for the current version or for iojs.